From 0e6f86bc8bd6a05101459b05e6d6fc3eff96c173 Mon Sep 17 00:00:00 2001 From: Lars Date: Thu, 20 Mar 2025 14:09:09 +0100 Subject: [PATCH] fix: :bug: unify value name and add default (#58) --- charts/jellyfin/templates/service.yaml | 2 +- charts/jellyfin/templates/serviceMonitor.yaml | 3 +-- charts/jellyfin/values.yaml | 2 ++ 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/charts/jellyfin/templates/service.yaml b/charts/jellyfin/templates/service.yaml index 518dc85..c5c252f 100644 --- a/charts/jellyfin/templates/service.yaml +++ b/charts/jellyfin/templates/service.yaml @@ -47,7 +47,7 @@ spec: externalTrafficPolicy: {{ . }} {{- end }} ports: - - name: {{ .Values.service.portName | default "http" }} + - name: {{ .Values.service.name | default "http" }} port: {{ .Values.service.port }} protocol: TCP targetPort: http diff --git a/charts/jellyfin/templates/serviceMonitor.yaml b/charts/jellyfin/templates/serviceMonitor.yaml index cc8b03d..a419875 100644 --- a/charts/jellyfin/templates/serviceMonitor.yaml +++ b/charts/jellyfin/templates/serviceMonitor.yaml @@ -14,7 +14,7 @@ metadata: {{- end }} spec: endpoints: - - port: {{ .Values.service.name }} + - port: {{ .Values.service.name | default "http" }} {{- with .Values.metrics.serviceMonitor.interval }} interval: {{ . }} {{- end }} @@ -23,7 +23,6 @@ spec: {{- end }} honorLabels: true path: {{ .Values.metrics.serviceMonitor.path }} - port: {{ .Values.metrics.serviceMonitor.port }} scheme: {{ .Values.metrics.serviceMonitor.scheme }} {{- with .Values.metrics.serviceMonitor.tlsConfig }} tlsConfig: diff --git a/charts/jellyfin/values.yaml b/charts/jellyfin/values.yaml index f936326..8d9638b 100644 --- a/charts/jellyfin/values.yaml +++ b/charts/jellyfin/values.yaml @@ -58,6 +58,8 @@ deploymentStrategy: type: RollingUpdate service: + # # -- Custom name for the service port + # name: http # -- Service type (ClusterIP, NodePort, or LoadBalancer). type: ClusterIP # -- Configure dual-stack IP family policy. See: https://kubernetes.io/docs/concepts/services-networking/dual-stack/