Commit Graph
2 Commits
  • test(init): add tests for initContainers deprecation and extraInitContainers
    Add helm-unittest tests for init containers:
    - No init containers by default
    - extraInitContainers support (single and multiple)
    - Full container spec preservation (command, args, volumeMounts, securityContext)
    - Backward compatibility with deprecated initContainers parameter
    - Merging of initContainers and extraInitContainers
    - Correct ordering when both are specified
    
    Add NOTES.txt with init containers information:
    - Show count of configured init containers
    - Deprecation warning when old initContainers parameter is used
    - Migration guidance to extraInitContainers
    
    This fixes the critical bug where extraInitContainers didn't work and
    provides clear migration path from deprecated initContainers.
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    Signed-off-by: Aleksei Sviridkin <f@lex.la>
  • fix(templates)!: deprecate initContainers in favor of extraInitContainers
    BREAKING CHANGE: The 'initContainers' parameter is now deprecated in favor
    of 'extraInitContainers' for naming consistency with 'extraContainers'.
    Both parameters will work until 2030 for backward compatibility.
    
    The previous implementation used '.Values.initContainers' in the template
    but 'extraInitContainers' was defined in values.yaml, causing the feature
    to be completely non-functional.
    
    Changes:
    - Fix extraInitContainers not working (was referencing wrong parameter)
    - Add deprecated 'initContainers' parameter to values.yaml with @deprecated tag
    - Update deployment.yaml to support both parameters with OR logic
    - Add TODO comment to remove initContainers support after 2030
    - Create NOTES.txt with:
      - Deprecation warning when using initContainers
      - Post-installation instructions for accessing Jellyfin
      - Persistence status information
      - Links to documentation
    - Improve extraInitContainers documentation with usage example
    - Bump chart version 2.5.0 -> 3.0.0 (major due to deprecation)
    - Add comprehensive changelog to artifacthub.io/changes
    
    Migration guide:
      Old: initContainers: [...]
      New: extraInitContainers: [...]
    
    The old parameter will continue to work but users will see a deprecation
    warning in NOTES.txt after installation.
    
    Follows best practices from community charts (Prometheus, Elastic, etc.)
    where 'extra*' prefix indicates user-provided extension points.
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    Signed-off-by: Aleksei Sviridkin <f@lex.la>