Updated all GitHub Actions from pinned SHA to stable version tags:
- actions/checkout: v4 → v5 (supports Node 24)
- actions/setup-python: v5 with Python 3.13 (explicit version)
- azure/setup-helm: v4 (stable)
- losisin/helm-docs-github-action: v1 (latest)
- helm/chart-testing-action: v2 (stable)
- DavidAnson/markdownlint-cli2-action: v16 → v18 (latest)
Changed from SHA pinning to semantic version tags for better
compatibility with act and easier maintenance. All versions verified
for 2025.
Tested with act dry-run - all steps succeed.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Fixed yamllint configuration and values.yaml issues:
- Added ignore patterns for templates/ and .github/ directories to yamllint config
(Helm templates contain Go template syntax that conflicts with YAML syntax)
- Removed trailing spaces from values.yaml:123 (nodePort comment)
- Regenerated README.md with helm-docs to sync with values.yaml changes
yamllint now passes without errors (only warnings remain for long lines in docs).
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Fixed comprehensive test suite to achieve 100% pass rate (603/603 tests).
Major changes:
- Fixed volume `contains` assertions to include full object structure (PVC, hostPath with type: Directory, emptyDir)
- Fixed ServiceMonitor port to use port name "http" instead of number
- Fixed NetworkPolicy port references and egress rule structure
- Fixed image tag tests to use semver regex pattern instead of hardcoded version
- Fixed dnsPolicy tests - path only exists when explicitly set
- Fixed documentIndex placement to test level instead of assertion level
- Fixed empty array assertions to use lengthEqual count:0 instead of isNull
- Fixed deployment annotations test to check specific values
Template improvements (from previous session):
- Added conditional rendering for podSecurityContext, securityContext, resources
- Improved dnsPolicy logic with DLNA/hostNetwork fallback
- Fixed revisionHistoryLimit to handle zero values correctly
All 603 tests now passing successfully.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
- Replace escaped dot notation (app\.kubernetes\.io/name) with bracket notation (["app.kubernetes.io/name"])
- Add missing templates to test suites (service.yaml, ingress.yaml, httpRoute.yaml, serviceaccount.yaml, persistentVolumeClaim.yaml)
- This fixes 40+ test failures related to unknown paths in labels and annotations
Test progress: 535/603 passing (89%), up from 495/603 (82%)
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
- Add automountServiceAccountToken to deployment.yaml template (was missing)
- Fix image.repository pattern in schema to allow registry with port (e.g., registry.example.com:5000)
- Add ExternalName to service.type enum in schema
- Remove ExternalName tests from service_test.yaml and validation_mutual_exclusions_test.yaml (not implemented in template)
- Fix integration test: change persistence.media.type from 'nfs' to 'hostPath' (nfs not supported)
These fixes address test failures related to schema validation and missing template fields.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Fix YAML syntax errors where patterns containing colons need to be quoted
to avoid being interpreted as YAML mapping values.
Affected files:
- deployment_image_test.yaml
- regression_defaults_test.yaml
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Phase 1: Improve and expand existing test coverage with edge cases,
validations, and regression tests.
Changes:
- Rename cache_persistence_test → persistence_test with full coverage
for config, media, and cache persistence (60+ tests)
- Rename service_ipv6_test → service_test with full service coverage
including types, ports, annotations, LoadBalancer settings (80+ tests)
- Rename startup_probe_test → probes_test covering all three probe types:
startup, liveness, readiness with all configurations (60+ tests)
- Expand networkpolicy_test with IPv4/IPv6 CIDR validations, egress
restrictions, and edge cases (+13 tests)
- Expand init_containers_test with full container spec and merge order
validation (+5 tests)
- Expand envfrom_test with prefix, optional, and multiple source
combinations (+9 tests)
Test coverage improvements:
- All edge cases for persistence types (pvc, hostPath, emptyDir)
- Service type validation (ClusterIP, NodePort, LoadBalancer, ExternalName)
- Probe types validation (httpGet, tcpSocket, exec)
- NetworkPolicy CIDR format validation (IPv4/IPv6)
- Comprehensive regression tests for default behavior
Total: 6 improved test files, 230+ new test cases
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Streamline post-installation notes from 296 to 88 lines:
- Keep essential deprecation warnings (initContainers)
- Keep error warnings (NetworkPolicy conflicts)
- Keep access instructions based on service type
- Keep persistence warnings
- Remove excessive details about features
- Replace emoji with ASCII (*** WARNING ***, *** ERROR ***) to maintain monospace alignment
- Ensure all banner lines are exactly 77 characters
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add values.schema.json with comprehensive validation for chart values:
- All core fields with types, defaults, and enums
- Validation preventing NetworkPolicy + hostNetwork conflicts
- Validation preventing NetworkPolicy + DLNA conflicts
The schema uses JSON Schema draft-07 with allOf/if-then logic to enforce
mutual exclusivity: networkPolicy.enabled cannot be true when either
jellyfin.enableDLNA or podPrivileges.hostNetwork is true.
Validated with check-jsonschema against current values.yaml and
test cases for both valid and invalid configurations.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Fix duplicate description field in NetworkPolicy/inotify changelog entries.
The changelog had two description fields in one entry which is invalid YAML.
Split into two separate changelog items.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Resolve conflicts by combining inotify troubleshooting documentation with
all features from master-vnext integration branch:
- inotify troubleshooting docs (this branch)
- HTTPRoute support
- envFrom support
- Startup probe
- Cache persistence
- IPv6 dual-stack
- revisionHistoryLimit
- initContainers deprecation
Updated version to 3.0.0 and merged all changelog entries.
Regenerated README.md from template.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Resolve conflicts by combining NetworkPolicy feature with all features from
master-vnext integration branch:
- NetworkPolicy support (this branch)
- HTTPRoute support
- envFrom support
- Startup probe
- Cache persistence
- IPv6 dual-stack
- revisionHistoryLimit
- initContainers deprecation
Updated version to 3.0.0 and merged all changelog entries.
Regenerated README.md from template.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Automatically extract and format changelog from artifacthub.io/changes
annotations in Chart.yaml and update GitHub release notes.
Changes:
- Install yq for YAML parsing
- Add step to extract changelog from Chart.yaml
- Format changelog with emojis based on change kind (added, fixed, etc.)
- Build comprehensive release notes with:
- Chart and app versions
- Formatted changelog
- Installation and upgrade instructions
- Links to documentation
- Update release notes after chart-releaser creates the release
This addresses the issue where releases only contained "A Helm chart for
Jellyfin Media Server" without any information about what changed.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest tests for revisionHistoryLimit:
- Default value (3) verification
- Custom values support (0, 1, 5, 100)
- Ability to disable revision history
Add NOTES.txt with revisionHistoryLimit information:
- Show configured revision history limit
- Warning when disabled (0)
- Note for minimal history (1)
- Rollback command example for normal values
This parameter controls how many old ReplicaSets are retained
for rollback purposes, reducing etcd storage usage.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add revisionHistoryLimit parameter to control how many old ReplicaSets are
retained for rollback purposes, reducing etcd storage usage compared to
Kubernetes default of 10.
Changes:
- Add revisionHistoryLimit parameter in values.yaml (default: 3)
- Add revisionHistoryLimit to deployment.yaml spec
- Provide comprehensive documentation with recommendations
- Bump chart version 2.5.0 -> 2.5.1 (patch - minor enhancement)
- Add changelog annotation for Artifact Hub
Benefits:
- Reduce etcd storage usage (especially important in large clusters)
- Maintain reasonable rollback capability (3 previous versions)
- Allow customization based on deployment needs
- Can be set to null to use Kubernetes default (10)
Default rationale:
- 3 revisions provides sufficient rollback capability for most use cases
- Reduces cluster resource usage (etcd storage, API server load)
- Follows best practices from production Kubernetes deployments
- Users can override if they need more history
Example usage:
# Use default (3 revisions)
revisionHistoryLimit: 3
# Increase for critical deployments
revisionHistoryLimit: 10
# Use Kubernetes default (10)
revisionHistoryLimit: null
# Disable history (not recommended)
revisionHistoryLimit: 0
See: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#revision-history-limit
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest tests for envFrom functionality:
- No envFrom by default
- ConfigMap reference support
- Secret reference support
- Multiple envFrom sources
- Optional ConfigMap/Secret support
- Prefix support for variable namespacing
- Compatibility with regular env variables
Add NOTES.txt with envFrom information:
- Show count of envFrom sources
- List each source (ConfigMap or Secret)
- Display optional and prefix settings
Tests ensure envFrom works correctly for loading environment
variables from ConfigMaps and Secrets.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest tests for init containers:
- No init containers by default
- extraInitContainers support (single and multiple)
- Full container spec preservation (command, args, volumeMounts, securityContext)
- Backward compatibility with deprecated initContainers parameter
- Merging of initContainers and extraInitContainers
- Correct ordering when both are specified
Add NOTES.txt with init containers information:
- Show count of configured init containers
- Deprecation warning when old initContainers parameter is used
- Migration guidance to extraInitContainers
This fixes the critical bug where extraInitContainers didn't work and
provides clear migration path from deprecated initContainers.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest tests for startup probe:
- Default configuration verification (tcpSocket, timing)
- Custom timing parameters (initialDelaySeconds, periodSeconds, failureThreshold)
- Alternative probe types (httpGet)
- Custom port support
- Timeout window calculation
Add NOTES.txt with startup probe information:
- Display max startup time calculation
- Explain startup probe purpose for large libraries
- Warning for very long startup timeouts
Tests ensure startup probe works correctly for slow initial startup scenarios.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add NOTES.txt with:
- Basic access instructions (Ingress or port-forward)
- Reference to troubleshooting documentation in README
- Links to Jellyfin documentation
This complements the inotify troubleshooting documentation added
in README.md.gotmpl, making users aware of available resources.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest tests for IPv6 and dual-stack Service configuration:
- Default behavior (no ipFamilyPolicy/ipFamilies set)
- SingleStack, PreferDualStack, RequireDualStack policies
- IPv4 only, IPv6 only configurations
- Dual-stack with IPv4 primary and IPv6 primary
- Combined policy and families configurations
Add NOTES.txt with IPv6/dual-stack information:
- Display configured IP family policy
- Show IP families list
- Warning when IPv6 is primary (probe compatibility note)
- Warning when IPv6 used without policy
Tests ensure IPv6 and dual-stack work correctly for all scenarios.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add helm-unittest test suite for HTTPRoute (Gateway API) covering:
- Not created by default (enabled: false)
- Created when enabled with required configuration
- Annotations support
- parentRefs configuration (name, namespace, sectionName)
- Hostnames support (single and multiple)
- Path matching rules (PathPrefix, Exact)
- Multiple rules and multiple matches per rule
- Backend references to Jellyfin service
- Custom service port handling
Add NOTES.txt with HTTPRoute-specific deployment information:
- Gateway references and configuration status
- Configured hostnames
- Number of routes
- Backend service details
- Access URLs when hostnames configured
- Warnings for missing parentRefs
Tests ensure HTTPRoute works correctly across all Gateway API scenarios.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Regenerate README.md from README.md.gotmpl template using helm-docs.
This adds the complete NetworkPolicy documentation section and updates
the values table with all networkPolicy configuration parameters.
The generated documentation includes:
- Updated version badge (2.6.0)
- Complete networkPolicy values table with descriptions
- Network Security section with examples and troubleshooting
- All parameters from values.yaml with auto-generated descriptions
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Bump chart version from 2.5.0 to 2.6.0 (minor version) for new feature.
Added artifacthub.io/changes annotations:
- NetworkPolicy support for network isolation and security hardening
- NOTES.txt with deployment status and configuration summary
This is a backward-compatible change:
- NetworkPolicy is disabled by default
- Existing installations will not be affected
- Users can opt-in to NetworkPolicy by setting networkPolicy.enabled=true
The NetworkPolicy feature provides enterprise-grade network security
controls for Jellyfin deployments in Kubernetes environments with
CNI plugin support.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add NOTES.txt template that displays helpful information after deployment:
- How to access Jellyfin (via Ingress or port-forward)
- NetworkPolicy status and configuration summary when enabled
- Ingress policy details (allowExternal, selectors, Prometheus)
- Egress policy details (DNS, internet access, restrictions)
- Warnings for misconfigurations (no selectors, DNS disabled)
- Compatibility note about CNI requirements
- Warning if NetworkPolicy + hostNetwork are both enabled
The NOTES provide immediate visibility into the deployment configuration
and help users quickly identify and troubleshoot network access issues.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add networkPolicy section to values.yaml with comprehensive configuration options:
- enabled: boolean flag to enable/disable NetworkPolicy (default: false)
- policyTypes: configure Ingress and/or Egress policies
- ingress: control which pods/namespaces can access Jellyfin
- allowExternal: permit access from any namespace (default: true)
- podSelector/namespaceSelector: restrict access to specific pods/namespaces
- customRules: advanced ingress rules for complex scenarios
- egress: control outbound connections from Jellyfin
- allowDNS: permit DNS resolution (default: true, required)
- allowAllEgress: permit all internet access (default: true)
- restrictedEgress: high-security mode with HTTPS-only metadata access
- customRules: advanced egress rules
- metrics: automatic Prometheus integration configuration
All parameters include detailed documentation explaining:
- Purpose and usage
- Default values and recommended settings
- Examples for common scenarios
- Security implications
The configuration supports use cases from simple deployments to
zero-trust environments while maintaining sensible defaults.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add comprehensive NetworkPolicy support for Jellyfin pod with:
- Ingress rules: configurable external access or namespace/pod selectors
- Egress rules: DNS resolution, metadata providers, custom rules
- Automatic Prometheus integration when metrics are enabled
- DLNA/hostNetwork detection with fail-safe error message
- Support for restrictedEgress mode for high-security environments
The NetworkPolicy is disabled by default to maintain backward compatibility.
When enabled, it provides fine-grained control over network traffic:
- Who can access Jellyfin (ingress)
- What external connections Jellyfin can make (egress)
NetworkPolicy requires CNI plugin support (Calico, Cilium, etc.) and
cannot be used with hostNetwork mode (DLNA). The template includes
validation to prevent misconfiguration.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add support for loading environment variables from ConfigMap or Secret
resources using envFrom field, following Kubernetes best practices for
configuration management.
Changes:
- Add jellyfin.envFrom parameter in values.yaml
- Add envFrom section in deployment.yaml template (before env)
- Provide comprehensive documentation with examples
- Bump chart version 2.5.0 -> 2.6.0 (minor - new feature)
- Add changelog annotation for Artifact Hub
Use cases:
- Load multiple environment variables from ConfigMap without defining each one
- Load secrets from external secret management systems
- Separate configuration from chart values (12-factor app pattern)
- Simplify configuration for complex deployments
Example usage:
jellyfin:
envFrom:
- configMapRef:
name: jellyfin-config
- secretRef:
name: jellyfin-secrets
Follows standard Kubernetes patterns used by most community Helm charts.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
BREAKING CHANGE: The 'initContainers' parameter is now deprecated in favor
of 'extraInitContainers' for naming consistency with 'extraContainers'.
Both parameters will work until 2030 for backward compatibility.
The previous implementation used '.Values.initContainers' in the template
but 'extraInitContainers' was defined in values.yaml, causing the feature
to be completely non-functional.
Changes:
- Fix extraInitContainers not working (was referencing wrong parameter)
- Add deprecated 'initContainers' parameter to values.yaml with @deprecated tag
- Update deployment.yaml to support both parameters with OR logic
- Add TODO comment to remove initContainers support after 2030
- Create NOTES.txt with:
- Deprecation warning when using initContainers
- Post-installation instructions for accessing Jellyfin
- Persistence status information
- Links to documentation
- Improve extraInitContainers documentation with usage example
- Bump chart version 2.5.0 -> 3.0.0 (major due to deprecation)
- Add comprehensive changelog to artifacthub.io/changes
Migration guide:
Old: initContainers: [...]
New: extraInitContainers: [...]
The old parameter will continue to work but users will see a deprecation
warning in NOTES.txt after installation.
Follows best practices from community charts (Prometheus, Elastic, etc.)
where 'extra*' prefix indicates user-provided extension points.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add startupProbe to give Jellyfin sufficient time to start, especially
with large media libraries or slow storage. This prevents Kubernetes
from killing the pod during initial startup phase.
Changes:
- Add startupProbe configuration in values.yaml with sensible defaults
- failureThreshold: 30 (allows up to 5 minutes for startup)
- periodSeconds: 10
- Uses tcpSocket check on http port
- Update deployment.yaml to include startupProbe from values
- Bump chart version 2.5.0 -> 2.5.1
- Add changelog annotation for Artifact Hub
Benefits:
- Prevents pod restarts during slow initial startup (large media libraries)
- Liveness and readiness probes remain responsive after successful startup
- Fully configurable and can be disabled by setting startupProbe: null
- No breaking changes, backward compatible
The startup probe gives Jellyfin up to 5 minutes (30 attempts * 10 seconds)
to complete initialization. After the first success, liveness and readiness
probes take over with their normal timing.
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add comprehensive troubleshooting documentation for inotify instance limit
errors that cause Jellyfin crashes in environments with many containers.
Changes:
- Add Troubleshooting section to README with inotify limits explanation
- Document proper solution: increase kernel limits via sysctl
- Provide workaround for managed clusters: DOTNET_USE_POLLING_FILE_WATCHER
- Add commented example in values.yaml for easy copy-paste
- Update Chart version from 2.5.0 to 2.5.1
- Add Artifact Hub changelog annotation
The proper solution is to increase inotify limits on Kubernetes nodes:
```bash
sysctl -w fs.inotify.max_user_instances=512
```
For managed Kubernetes where node access is restricted, users can use the
polling workaround (less efficient but functional):
```yaml
jellyfin:
env:
- name: DOTNET_USE_POLLING_FILE_WATCHER
value: "1"
```
This addresses the crash issue mentioned in #64.
Fixes: #64
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add dedicated cache volume configuration to reduce wear on SD cards and improve
performance by allowing cache to be stored on separate storage.
Changes:
- Add persistence.cache configuration in values.yaml with support for:
- PVC (default type when enabled)
- hostPath for direct host mount
- emptyDir (default when disabled)
- Add cache volume mount at /cache in deployment
- Add cache PersistentVolumeClaim template
- Support for existing PVC via existingClaim
- Configurable size (default 10Gi), accessMode, storageClass, and annotations
- Update Chart version from 2.5.0 to 2.5.1
- Add Artifact Hub changelog annotation
The cache volume is disabled by default to maintain backward compatibility.
Users can enable it via:
```yaml
persistence:
cache:
enabled: true
type: pvc
size: 10Gi
```
This addresses the use case mentioned in #62 where users want to avoid SD card
wear by storing cache on separate persistent storage.
Fixes: #62
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Change default health probes from tcpSocket to httpGet to fix issue #68
where pods fail to start in IPv6-only clusters due to incompatible health checks.
Changes:
- Change default livenessProbe and readinessProbe to use httpGet with /health endpoint
- Add comprehensive IPv6 and dual-stack configuration documentation
- Document ipFamilyPolicy options (SingleStack, PreferDualStack, RequireDualStack)
- Document ipFamilies configuration for IPv4-only, IPv6-only, and dual-stack setups
- Add IPv6 Configuration section to README with examples
- Update Chart version from 2.5.0 to 2.5.1
The httpGet probe works with both IPv4 and IPv6 out of the box, while tcpSocket
may fail in IPv6-only environments. Jellyfin's /health endpoint is specifically
designed for health checks and verifies both HTTP and database connectivity.
Fixes: #68
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
Add support for Kubernetes Gateway API HTTPRoute resource as a modern
alternative to Ingress. The implementation follows the same pattern as
the existing Ingress template.
Changes:
- Add HTTPRoute template with configurable parentRefs, hostnames, and rules
- Add httpRoute section to values.yaml with generic examples
- Update Chart version from 2.5.0 to 2.6.0
- Add Artifact Hub changelog annotation
- Add HTTPRoute documentation to README
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>